Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for non-MIT licensed codes #1000

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Conversation

junkoda
Copy link
Contributor

@junkoda junkoda commented Dec 6, 2024

This is the change I propose in the issue #997

  • Modify the license sentence in top README
  • Add licenses directory

I am unfamiliar to contributing to large open source projects. Let me know if there was anything that should have been done differently (Should I clean commits to one commit? Is the base branch main?). Thanks!

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking great to me! Please add .md for _apple, _nvidia files and we are good to merge it!

@junkoda
Copy link
Contributor Author

junkoda commented Dec 6, 2024

Certainly! Wait! link to those licenses are not correct. Fixed.
Change to .md is done and should be fine.

@qubvel qubvel merged commit 5c42e61 into qubvel-org:main Dec 7, 2024
1 check passed
@qubvel
Copy link
Collaborator

qubvel commented Dec 7, 2024

Thanks for contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants